(freecad) 32/64bit detection and shim logic

[RedBaron2]

@AdmiringWorm @majkinetor @pauby @gep13

Description

This will fix the non-matching versioning between the 32/64bit urls #1635 . This will also fix issue #1616 of no shims with new logic.

Motivation and Context

How Has this Been Tested?

Screenshot (if appropriate, usually isn't needed):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Migrated package (a package has been migrated from another repository)

Checklist:

• My code follows the code style of this repository.
• My change requires a change to documentation (this usually means the notes in the description of a package).
• I have updated the documentation accordingly (this usually means the notes in the description of a package).
• All files are up to date with the latest Contributing Guidelines
• The added/modified package passed install/uninstall in the chocolatey test environment.
• The changes only affect a single package (not including meta package).

Original Location

• Original Repository
• Open Issues Add the different issues underneath, and tick those that are fixed in this PR
  • Issue (freecad) no shims are created #1616
  • Issue (freecad) package file url incorrect #1637
• Include the link to the opened PR that removes the package from the original location
• The migration guidelines have been followed

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[adrianinsaval]

Does this install shims for the installer version too? I think that needs to be done with the Install-Binfile command: https://docs.chocolatey.org/en-us/create/functions/install-binfile

[RedBaron2]

@adrianinsaval
I was unaware of missing shims on the install version. Normally the shims are created so the program can be used from the command or powershell prompt(s).

If you have any further info to share it could be very helpful, thanks.

[adrianinsaval]

I couldn't test since the install version is broken but I don't see anything that indicates that a shim would be created in the script, my understanding is that this would install freecad to the default location (C:\Program Files\FreeCAD 0.19) and I think chocolatey doesn't auto generate shims for binaries outside of the lib folder.

On an entirely separate issue, the dev version will apparently no longer be published in the main freecad repo, I'm trying to get a definitive answer of where they will be published going forward, they are currently here: https://github.com/FreeCAD/FreeCAD-AppImage/releases/tag/weekly-builds

[adrianinsaval]

@RedBaron2 FreeCAD dev releases will now be published here: https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds do you think you can change that too in this PR or should I create a new issue for this?

[RedBaron2]

@adrianinsaval
I'll look into changing this in the week. Thanks for letting me know.

[RedBaron2]

@adrianinsaval
I'm just curious now that I got to look closer at the weekly-builds page. The developers are recommending users switch to the vc17 version instead of the vc14 version.

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[RedBaron2]

@AdmiringWorm @majkinetor @pauby @pascalberger @gep13
This PR is updated to also fix the new dev url, and newer regex for installer-1, installer1, and installer files.

This will also update the shim logic.

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[RedBaron2]

I will close this for now, and start it fresh in a few.