Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall failure to delete backup should not set the package as a failure #1139

Open
ferventcoder opened this issue Jan 15, 2017 · 5 comments
Assignees
Milestone

Comments

@ferventcoder
Copy link
Member

example

This may be a duplicate but just wanted to get the issue logged

@ferventcoder ferventcoder added this to the 0.10.4 milestone Jan 15, 2017
@ferventcoder ferventcoder self-assigned this Jan 21, 2017
@ferventcoder
Copy link
Member Author

ferventcoder commented Mar 21, 2017

This is maybe on upgrade with a previous backup folder already in place that is locked.

@ferventcoder
Copy link
Member Author

ferventcoder commented Mar 21, 2017

rstrahl ^^ it looks like we don't fail on the failure to remove the backup directory. It could be there is an issue during upgrade.

@ferventcoder
Copy link
Member Author

Okay, forgive me and my ability to read. However during uninstall it calls that same set of code. Next time you run into this, can you provide the full log so that we can more easily pinpoint where this occurs? Thanks!

@ferventcoder ferventcoder modified the milestones: 0.10.5, 0.10.4 Mar 21, 2017
@gep13
Copy link
Member

gep13 commented Mar 23, 2017

@ferventcoder think you might have been wanting @RickStrahl 😄

@ferventcoder
Copy link
Member Author

Yes...my bad

@ferventcoder ferventcoder modified the milestones: 0.10.5, 0.10.6, 0.10.7 Mar 30, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.7, 0.10.8 Jun 6, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.8, 0.10.9 Aug 27, 2017
@ferventcoder ferventcoder removed this from the 0.10.9 milestone Feb 27, 2018
@ferventcoder ferventcoder added this to the 0.10.10 milestone Feb 27, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.10, 0.10.11 Mar 27, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.11, 0.10.12 May 3, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.12, 0.10.13, 0.10.14 Mar 13, 2019
@ferventcoder ferventcoder modified the milestones: 0.10.14, 0.10.15 Apr 1, 2019
@gep13 gep13 modified the milestones: 0.10.15, 0.10.16 May 31, 2019
@pauby pauby modified the milestones: 0.10.16, 0.10.x May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants