Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnInstall-ChocolateyZipPackage removes folders that contain other files #2042

Open
flcdrg opened this issue May 2, 2020 · 0 comments
Open

Comments

@flcdrg
Copy link
Member

flcdrg commented May 2, 2020

What You Are Seeing?

I'm using Install-ChocolateyZipPackage to install an OBS plugin directly into c:\Program files\obs-studio, which was created earlier by installing the obs-studio package.

When I call UnInstall-ChocolateyZipPackage, it deletes folders that had files installed by the original OBS package in addition to the files installed by my plugin package.

What is Expected?

Delete files previously installed, but don't delete folders if there are other files remaining.

Example

Installing using Install-ChocolateyZipPackage created a file obs-ndi-4.9.0-Windows.zip.txt with the following contents:

C:\Program Files\obs-studio\data
C:\Program Files\obs-studio\data\obs-plugins
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale\ca-ES.ini
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale\en-US.ini
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale\es-ES.ini
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale\fr-FR.ini
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale\ru-RU.ini
C:\Program Files\obs-studio\obs-plugins
C:\Program Files\obs-studio\obs-plugins\32bit
C:\Program Files\obs-studio\data\obs-plugins\obs-ndi\locale\zh-CN.ini
C:\Program Files\obs-studio\obs-plugins\32bit\obs-ndi.dll
C:\Program Files\obs-studio\obs-plugins\32bit\obs-ndi.pdb
C:\Program Files\obs-studio\obs-plugins\64bit
C:\Program Files\obs-studio\obs-plugins\64bit\obs-ndi.dll
C:\Program Files\obs-studio\obs-plugins\64bit\obs-ndi.pdb

The current implementation deletes all the directories, even though many of these contained files installed by the obs-studio package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant