New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1541) Add priority ordering for repository optimizations #2286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor changes based on a quick review.
src/chocolatey/infrastructure.app/nuget/PriorityAggregateRepository.cs
Outdated
Show resolved
Hide resolved
@AdmiringWorm would it be possible for you to update this PR with the new template that we are using in other repositories, i.e. include information about the testing that was performed (in addition to the new tests which have been added - thanks for getting those added!) |
3ab6c9b
to
804b2d5
Compare
@gep13 I have fixed the requested changes, updated the template for the PR and changed the PR to target the develop branch (instead of the old master branch). The testing steps added was added from memory, and not the same exact steps I had done back when I opened the PR. |
804b2d5
to
4b004cc
Compare
This commit re-adds the ability to order sources according to a specified priority. This ability seems to have been lost due to changes in the codebase in the past and thus needed to be re-implemented when the repository optimization is enabled.
4b004cc
to
0fbed41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@AdmiringWorm I am going to go ahead and get this merged in. The failing AppVeyor build is something that I need to look at, but it is not as a result of the changes in this PR, since the GitHub Action builds are completing successfully. |
Description Of Changes
This pull requests re-adds the ability to order sources by priority when installing and upgrading packages.
Motivation and Context
Priority currently are not respected due to to sorting is done on prioritized sources.
Testing
Change Types Made
Related Issue
Fixes #1541
Change Checklist