Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nuget sources with complied nuget package that are used in tests #2828

Open
AdmiringWorm opened this issue Sep 22, 2022 · 2 comments
Labels
Tests Issues related to the tests (NUnit or Pester)

Comments

@AdmiringWorm
Copy link
Member

Is Your Feature Request Related To A Problem? Please describe.

Currently we have the sources of the packages that we use during the run of integration and E2E tests located in the repository, as well as other places that we use as the source of truth for these source files.

Describe The Solution. Why is it needed?

These should be replaced by already compiled binaries of the nuget package instead of having to built the packages themself when running these tests. This allows us to reduce the duplication and only have one place we can use as the source of truth for these packages.

This will require changes to the vagrant image available in the repository to set a local source to the location of the packages.

Additional Context.

N/A

Related Issues

N/A

@AdmiringWorm AdmiringWorm added the Tests Issues related to the tests (NUnit or Pester) label Sep 22, 2022
@AdmiringWorm
Copy link
Member Author

Additional notes that should be considered when working on this issue.

Currently we are using a few packages from the community repository as well, we should at the same time update the Invoke-Tests powershell helper to download these packages to the same directory that we will store the other nupkg files in.
The tests that make use of this are currently marked as internal and will not run during open source execution (since we disable the use of the community repository during tests).

@corbob
Copy link
Member

corbob commented Mar 11, 2023

We should also look to update the description and summary for the packages as mentioned here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Issues related to the tests (NUnit or Pester)
Projects
None yet
Development

No branches or pull requests

2 participants