Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro - Don't prompt to upload file for virus scanning if it is too large #695

Closed
flcdrg opened this issue Apr 18, 2016 · 2 comments

Comments

@flcdrg
Copy link
Contributor

commented Apr 18, 2016

What You Are Seeing?

User gets prompted to upload file for virus scanning. After responding with 'Y', the upload fails because the file exceeds the upload size limit.

What is Expected?

Don't prompt user and then fail if we can tell in advance that it won't work.

How Did You Get This To Happen? (Steps to Reproduce)

Ran choco upgrade sql-server-management-studio -pre just after a new release of SSMS, such that it hadn't been scanned by any of the providers used by Virus Total.

Output Log

2016-04-18 12:23:07,187 [INFO ] - Download of 'SSMS-Setup-ENU.exe' (815.42 MB) completed.
2016-04-18 12:23:09,197 [DEBUG] - Running 'Get-VirusCheckValid' with url:'http://download.microsoft.com/download/8/6/3/8639523C-7F12-4CC3-8D2F-908C7A78B4C6/SSMS-Setup-ENU.exe', file: 'C:\Users\David\AppData\Local\Temp\chocolatey\SQL Server Management Studio\13.0.14000.36-preview\SSMS-Setup-ENU.exe'
2016-04-18 12:23:09,233 [DEBUG] - Conducting virus check for 'SSMS-Setup-ENU.exe'.
2016-04-18 12:23:31,346 [WARN ] - Virus scan engines indicate this file has not been scanned before.
2016-04-18 12:23:31,356 [WARN ] - Upload file?
2016-04-18 12:23:31,362 [WARN ] - WARNING: Selecting Yes WILL upload the file to a PUBLIC website 
 and results will be publicly available. Do not select Yes for files
 that should be kept internal.
Upload 'SSMS-Setup-ENU.exe' for scanning?

2016-04-18 12:23:31,370 [WARN ] - [N] No [Y] Yes (default is "N")
2016-04-18 12:23:31,380 [WARN ] -   Confirmation (`-y`) is set.
  Respond within 30 seconds or the default selection will be chosen.
2016-04-18 12:23:40,556 [ERROR] - ERROR: The virus scanner cannot handle files over 500MB. 'SSMS-Setup-ENU.exe' 
 cannot be verified by the scanner. You must determine if it is safe 
 outside of choco and then to install with choco you will need to 
 pass --skip-virus-check to install this package.
@ferventcoder ferventcoder added this to the 0.9.10 milestone Apr 18, 2016
@ferventcoder ferventcoder self-assigned this Apr 18, 2016
@ferventcoder ferventcoder added Enhancement and removed Bug labels Apr 18, 2016
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

Probably best to do. At least we prompt to let the user know that the file is too big. Checking it sooner and not even offering to upload would be more beneficial, I agree. 👍

@ferventcoder ferventcoder changed the title Don't prompt to upload file for virus scanning if it is too large Pro - Don't prompt to upload file for virus scanning if it is too large Apr 18, 2016
@ferventcoder ferventcoder added 3 - Done and removed 0 - Backlog labels Apr 26, 2016
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

This is done, but the release it falls under is different. Normally I'd have you reach out through support channels on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.