(GH-153)(GH-134) Update PATH on cmd.exe

This adds a command RefreshEnv.cmd to the bin files, so that one can update
environment variables out of band. There is zero chance it will work once
chocolatey.cmd calls exit /b %ERRORLEVEL% as exiting the batch effectively
destroys any updates to local environmental changes. The way it currently
works is effectively the same as using setlocal due to the use of exit.

Since this command can be called out of band, it should be called out of
band, whenever the user wants to refresh their environment variables they
can call this. Note this only works in cmd.exe shell. There is no current way
to update a powershell session other than importing the helper functions as
a module and running Update-SessionEnvironment.

nuget/tools/chocolateysetup.psm1

@@ -113,7 +113,7 @@ param(
 )
 
   $redirectsPath = Join-Path $chocolateyInstallPath 'redirects'
-  $exeFiles = Get-ChildItem "$redirectsPath" -filter *.exe
+  $exeFiles = Get-ChildItem "$redirectsPath" -include @("*.exe","*.cmd") -recurse
   foreach ($exeFile in $exeFiles) {
     $exeFilePath = $exeFile.FullName
     $exeFileName = [System.IO.Path]::GetFileName("$exeFilePath")

src/chocolatey.cmd

@@ -15,7 +15,6 @@ IF NOT '%1'=='' SET PS_ARGS=%PS_ARGS:\\"=\"%
 
 @PowerShell -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = '';& '%DIR%chocolatey.ps1' %PS_ARGS%"
 SET ErrLvl=%ERRORLEVEL%
-call "%DIR%RefreshEnv.cmd"
 goto :exit
 
 :exit

src/RefreshEnv.cmd → src/redirects/RefreshEnv.cmd

@@ -7,17 +7,16 @@
 ::
 :: With this batch file, there should be no need to reload command
 :: environment every time you want environment changes to propagate
-::
 
-:: A strange trick to print without newline
-:: echo | set /p dummy="Reading environment variables from registry. Please wait... "
+echo | set /p dummy="Reading environment variables from registry. Please wait... "
+
 goto main
 
 :: Set one environment variable from registry key
 :SetFromReg
     "%WinDir%\System32\Reg" QUERY "%~1" /v "%~2" > "%TEMP%\_envset.tmp" 2>NUL
     for /f "usebackq skip=2 tokens=2,*" %%A IN ("%TEMP%\_envset.tmp") do (
-        echo/set "%~3=%%B"
+        echo/set %~3=%%B
     )
     goto :EOF
 
@@ -43,11 +42,7 @@ goto main
     call :SetFromReg "HKCU\Environment" Path Path_HKCU >> "%TEMP%\_env.cmd"
 
     :: Caution: do not insert space-chars before >> redirection sign
-    echo/set "Path=%%Path_HKLM%%;%%Path_HKCU%%" >> "%TEMP%\_env.cmd"
-
-    :: In final file: remove temp variables
-    echo/set "Path_HKLM=" >> "%TEMP%\_env.cmd"
-    echo/set "Path_HKCU=" >> "%TEMP%\_env.cmd"
+    echo/set Path=%%Path_HKLM%%;%%Path_HKCU%% >> "%TEMP%\_env.cmd"
 
     :: Cleanup
     del /f /q "%TEMP%\_envset.tmp" 2>nul
@@ -56,9 +51,5 @@ goto main
     :: Set these variables
     call "%TEMP%\_env.cmd"
 
-    :: Finish
-  ::  echo | set /p dummy="Done"
-    ::echo .
-
-
-exit /b %ERRORLEVEL%
+    echo | set /p dummy="Done"
+    echo .