[BUG] Renaming logs appending .old results in error

[ferventcoder]

If the success.log or failure.log already exists in the temp directory, the respective function will attempt to rename it to .old. In the functions, there is a line to join-path the path with ".old". Using the line below, the new path becomes c:\users\scott\appdata\temp\chocolatey\myapp\failure.log.old which generates an error when trying to rename the file.

Error Line
$oldSuccessLog = Join-Path "$successLog" '.old'

New Line
$oldSuccessLog = "$successLog".replace('.log','.old')

I am not an expert in Powershell and there might be a better option to the replace command. But using the replace command gave me the line c:\users\scott\appdata\temp\chocolatey\myapp\failure.old

You will see this line in both functions (Write-ChocolateySuccess.ps1 and
Write-ChocolateyFailure.ps1)

https://groups.google.com/group/chocolatey/browse_thread/thread/5e841b0219a5537?hl=en

[ferventcoder]

Fixed in 0f2318f