Skip to content
This repository has been archived by the owner on Feb 19, 2019. It is now read-only.

[Enhancement] Remove Invoke-ChocolateyFunction #446

Closed
ferventcoder opened this issue Mar 27, 2014 · 2 comments
Closed

[Enhancement] Remove Invoke-ChocolateyFunction #446

ferventcoder opened this issue Mar 27, 2014 · 2 comments
Assignees
@ferventcoder
Labels
v0.9.8.24

Comments

@ferventcoder
Copy link
Contributor

As noted in #418 - we have try catch wrapping the top level commands now so Invoke-ChocolateyFunction isn't necessary.
ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 27, 2014
@ferventcoder
(chocolatey-archiveGH-446) Remove Invoke-ChocolateyFunction
abe8bcc 
Now that we have the main commands wrapped with a try catch and non-zero exit
code, we don't need to funnel everything through this any longer, which
makes code readability better and actually fixes at least one bug
(Chocolatey-Verison was not throwing errors on non-existing packages due to
invocation always being through a function).
@jberezanski
Copy link
Contributor

Nice. For the record, this should also fix those two bugs:

@ferventcoder
Copy link
Contributor Author

Well then that's perfect. 👍

@jberezanski jberezanski mentioned this issue Mar 31, 2014
Closed
@ferventcoder ferventcoder self-assigned this Apr 3, 2014
@jberezanski jberezanski mentioned this issue Jun 24, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ferventcoder ferventcoder

Labels
v0.9.8.24
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ferventcoder @jberezanski