This repository has been archived by the owner on Feb 19, 2019. It is now read-only.
Source config implementation #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,9 +5,6 @@ param( | |||
| ) | |||
|
|
|||
| $srcArgs = "-source $source" | |||
| if ($source -like 'https://go.microsoft.com/fwlink/?LinkID=230477') { | |||
| $srcArgs = "-source http://chocolatey.org/" | |||
There was a problem hiding this comment.
Still need it to default to chocolatey as a source...
There was a problem hiding this comment.
The parameter defaults to chocolatey already:
[string] $source = 'http://chocolatey.org/'
Is this not sufficient? Just let me know if this needs to be backed out.
There was a problem hiding this comment.
My bad. I didn't RTFM, just the line above... :D
|
It's so much cleaner than all of that stuff I was doing... :D |
ghost
assigned 
|
Glad I can help. It was a good experience for me to get more familiar with git too. I appreciate it! |
|
This is in. Thanks! |
|
Cool! Glad I could help :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the source argument defaults used in all the functions.
I have added a new Get-SourceArgument function to wrap the logic for handling the source argument generation.
This new function is then used in Chocolatey-List, Chocolatey-Version, and Run-Get functions.
Basic logic used in Get-SourceArgument: