[Enhancement] Added FTP support for the chocolatey file downloader. #137
Conversation
….ps1 script modeled after the existing Get-WebFile.ps1.
…-FtpFile.ps1 script modeled after the existing Get-WebFile.ps1." This reverts commit 11e566e.
Added new Get-FtpFile.ps1 script modeled after the existing Get-WebFile.ps1 and integrated the function into Get-ChocolateyWebFile.ps1 so that URLs that begin with 'ftp' are processed using Get-FtpFile.
|
did the line-feeds or spacing change? not sure why it shows the whole file changed... |
|
That's cool. And I can see it shows even the progress? |
|
Yup, it shows the progress as well. It is implemented almost identically to On Sun, Aug 12, 2012 at 8:57 AM, noomorph notifications@github.com wrote:
|
ghost
assigned 
|
I have two pull requests for FTP support. Probably time to start a document on "So you want to contribute?" |
|
I like this...quite a bit. Whatever you do though, don't update your repository with my latest changes. I think that document for contributions is going to get written soon. We usually want people to contribute pull requests from a branch that is not master. That allows you to contribute multiple patches that way and doesn't get us into where we need to cherry pick your commits to keep the history in a nice straight line. |
|
Any updates on this? I have a number of packages that i would like to upload pending this patch's acceptance. It is unclear to me if there is something else you would like me to do. |
|
we'll be pulling it in soon. |
|
This is in...thanks for the contribution! |
|
This won't work of course until we release the next version of chocolatey (0.9.8.20), but that should be by the end of the month. You can download and play with a prerelease version now. |
|
I'm sooo waiting for this feature, it was working by accident for a while. One of my earliest packages was on an FTP server (prime95). I think the enhancements around the Something to consider in general, the |
|
This goes out into full release in a couple of days. So many new things being added. :D |
Emulated existing Get-WebFile functionality using the FTP protocol. It could conceivably be merged together with the HTTP request, but the .net request/response objects are slightly different (i.e. the FTP request doesn't support cookies).