This repository has been archived by the owner on Feb 19, 2019. It is now read-only.
Fix non-ASCII characters + add Chocolatey-Version tests #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit dcfb750, the copyright character (Windows-1252 0xA9) somehow got replaced with three bytes EF BF BD, which, despite resembling UTF-8, do not encode a valid Unicode codepoint (U+FDFF is undefined). Replace those bytes with simple ASCII (c) to keep Chocolatey code character set as generic as possible.
En dashes (U+2013) usually appear when writing code snippets in word processors or html editors, which make an effort to replace minus signs with nicer looking en and em dashes. Nicer for text documents, but not for code. PowerShell actually tolerates en dashes, but some text manipulation tools do not. Moreover, those are the only symbols outside of ASCII charset in Chocolatey code. Replace them with standard minus signs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chocolatey-Version.ps1 uses dash characters that are not standard ASCII minus signs, but Unicode "en" dashes (probably caused by copy-pasting from a word processor) in command invocations. The Powershell parser actually handles it, but some text manipulation tools have problems.
InstallChocolatey.ps1 contains an invalid sequence of bytes that once represented the copyright character, but got corrupted. Replace it with plain ASCII "(c)".
Also add some smoke tests for Chocolatey-Version.