Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installed packages problem with -pre packages #39

Closed
chrissie1 opened this issue Feb 14, 2013 · 6 comments
Closed

installed packages problem with -pre packages #39

chrissie1 opened this issue Feb 14, 2013 · 6 comments
Labels
Bug Issues where something has happened which was not expected or intended
Milestone

Comments

@chrissie1
Copy link
Contributor

the algo has a problem doing a good job when the name ends in -pre like ChocolateyGUI.0.1.5-pre

@ghost ghost assigned chrissie1 Feb 14, 2013
@chrissie1
Copy link
Contributor Author

Added failing tests for this.

gep13 added a commit that referenced this issue Feb 14, 2013
Due to an earlier, higher, version number for the setup msi, increasing
overall version number to start at 0.11.0
@gep13
Copy link
Member

gep13 commented Feb 14, 2013

Fixed :-)

@gep13 gep13 closed this as completed Feb 14, 2013
@chrissie1
Copy link
Contributor Author

this is not the issue you fixed ;-) you fixed something else.

@chrissie1 chrissie1 reopened this Feb 15, 2013
@gep13
Copy link
Member

gep13 commented Feb 15, 2013

Ah sorry! :-(

@tarwn
Copy link
Contributor

tarwn commented Feb 16, 2013

Which failing test was the one specific to this? is it possible I fixed it with the string -> package tests + regex update?

@chrissie1
Copy link
Contributor Author

If both tests are passing then yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Development

No branches or pull requests

3 participants