Skip to content

Commit

Permalink
(GH-607) Pack strips out Choco specific metadata
Browse files Browse the repository at this point in the history
This addresses chocolatey/choco#607 - the
manifest in 2.11 has a secondary path. I find it interesting that both
are there doing nearly the same thing. Fixed this to both use a method
to get Metadata so there is no longer a violation of DRY.
  • Loading branch information
ferventcoder committed Feb 4, 2016
1 parent fa884f8 commit 4e28997
Showing 1 changed file with 9 additions and 27 deletions.
36 changes: 9 additions & 27 deletions src/Core/Authoring/Manifest.cs
Expand Up @@ -131,6 +131,11 @@ private static string GetSchemaNamespace(XDocument document)
}

public static Manifest Create(IPackageMetadata metadata)
{
return CreateManifestWithMetadata(metadata);
}

private static Manifest CreateManifestWithMetadata(IPackageMetadata metadata)
{
return new Manifest
{
Expand Down Expand Up @@ -173,33 +178,10 @@ public static Manifest Create(PackageBuilder packageBuilder)
{
var metadata = (IPackageMetadata)packageBuilder;

return new Manifest
{
Metadata = new ManifestMetadata
{
Id = metadata.Id.SafeTrim(),
Version = metadata.Version.ToStringSafe(),
Title = metadata.Title.SafeTrim(),
Authors = GetCommaSeparatedString(metadata.Authors),
Owners = GetCommaSeparatedString(metadata.Owners) ?? GetCommaSeparatedString(metadata.Authors),
Tags = String.IsNullOrEmpty(metadata.Tags) ? null : metadata.Tags.SafeTrim(),
LicenseUrl = ConvertUrlToStringSafe(metadata.LicenseUrl),
ProjectUrl = ConvertUrlToStringSafe(metadata.ProjectUrl),
IconUrl = ConvertUrlToStringSafe(metadata.IconUrl),
RequireLicenseAcceptance = metadata.RequireLicenseAcceptance,
DevelopmentDependency = metadata.DevelopmentDependency,
Description = metadata.Description.SafeTrim(),
Copyright = metadata.Copyright.SafeTrim(),
Summary = metadata.Summary.SafeTrim(),
ReleaseNotes = metadata.ReleaseNotes.SafeTrim(),
Language = metadata.Language.SafeTrim(),
DependencySets = CreateDependencySets(metadata),
FrameworkAssemblies = CreateFrameworkAssemblies(metadata),
ReferenceSets = CreateReferenceSets(metadata),
MinClientVersionString = metadata.MinClientVersion.ToStringSafe(),
ContentFiles = packageBuilder.ContentFiles.ToList()
},
};
var manifest = CreateManifestWithMetadata(metadata);
manifest.Metadata.ContentFiles = packageBuilder.ContentFiles.ToList();

return manifest;
}

private static string ConvertUrlToStringSafe(Uri url)
Expand Down

0 comments on commit 4e28997

Please sign in to comment.