Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (unnecessary) application launcher and add <setup> meta-data #10

Closed
wants to merge 1 commit into from
Closed

Conversation

mahiuchun
Copy link

ibus-hangul seems to be the only engine that uses its own application launcher.
Though Unity from Ubuntu blocks the menu mode of IBus.
"Preferences" button in ibus-setup can be an alternative.
I've tested my commits on Ubuntu 12.04

Reference:
http://code.google.com/p/ibus/issues/detail?id=1495

@mahiuchun
Copy link
Author

Do you really want to remove the application launcher entirely? (50e4967 and 8eee6ea)
Alternatively, you can just hide it.
3d88a6c seems unless for Fedora/IBus 1.4.99 environment. It is necessary for Ubuntu 12.04 environment though.

@choehwanjin
Copy link
Member

Yes, let's remove it.
I prefer just 1 commit for this change.
ibus-setup should be able to launch ibus-setup-hangul without the commit 3d88a6c.
So, could you please make a commit for this change from the rest two commits 50e4967 8eee6ea.

@mahiuchun mahiuchun closed this Oct 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants