Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 Compatability #27

Closed
zslabs opened this issue Aug 16, 2016 · 9 comments
Closed

IE11 Compatability #27

zslabs opened this issue Aug 16, 2016 · 9 comments
Labels

Comments

@zslabs
Copy link
Contributor

zslabs commented Aug 16, 2016

Hi,
Using IE11 (with an addition of https://cdn.polyfill.io/v2/polyfill.min.js?features=default,matchMedia,fetch,Element.prototype.placeholder,Array.prototype.includes to hopefully grab everything I'd need to for compatibility since I was seeing fetch used) the UI isn't responding correctly; selections are not being added to the list of options; they just disappear. Are there any additional deps I should be using to solidify the browser support?

@jshjohnson
Copy link
Collaborator

Hi @zslabs;

Would you be able to send me your config for Choices so I can try and identify the issue?

Thanks

@zslabs
Copy link
Contributor Author

zslabs commented Aug 16, 2016

Hey!
I was testing the default GH pages build (locally) under VirtualBox's modernIE build of IE11.

@jshjohnson
Copy link
Collaborator

Hi @zslabs,

This has been resolved as of version 1.1.3. IE doesn't support DocumentFragment.children so I've opted for DocumentFragment.childNodes instead.

Thanks

@zslabs
Copy link
Contributor Author

zslabs commented Aug 17, 2016

Awesome! Thanks so much for jumping on that; can confirm it's working as expected. Appreciate it!

@rstacruz
Copy link
Contributor

rstacruz commented Mar 1, 2017

I think we still have some IE11 issues. Searching doesn't seem to work. I'll update if I can make a replicable test case.

@caycecollins
Copy link

caycecollins commented Mar 31, 2017

I'm seeing issues with ie11, due to the unsupported es2015 code in the index file:

SCRIPT1002: Syntax error
Choices (249,31)

249        addItemText: (value) => {
250          return `Appuyez sur Entrée pour ajouter <b>"${value}"</b>`;
251        },

@jshjohnson
Copy link
Collaborator

jshjohnson commented Mar 31, 2017

Hi @inergy,

Is this on the demo site or your own code?

Thanks

@caycecollins
Copy link

caycecollins commented Mar 31, 2017

On the demo site and I've cloned the repo and can reproduce locally. The index.html file has es2015 code, which I tracked it down to these commits:

I did a quick refactor using es5 and things started working as expected (after fixing the arrow functions and template literals).

@jshjohnson
Copy link
Collaborator

Thanks for the heads up - this should now be resolved with these two commits:

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants