Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of artifactId with dots #5

Closed
zielezin opened this issue Sep 28, 2017 · 1 comment
Closed

Incorrect handling of artifactId with dots #5

zielezin opened this issue Sep 28, 2017 · 1 comment

Comments

@zielezin
Copy link

Hi Chonton,

I tried to use your plugin and stumbled on a problem.
When the artifactId contains dots the url created during verification is build incorrectly.

For example artifact available in central repo:
http://central.maven.org/maven2/org/eclipse/rap/org.eclipse.rap.rwt/3.3.0/org.eclipse.rap.rwt-3.3.0.jar

Actual url created by plugin is:
http://central.maven.org/maven2/org/eclipse/rap/org/eclipse/rap/rwt/3.3.0/org.eclipse.rap.rwt-3.3.0.jar

I've traced this to
https://github.com/chonton/exists-maven-plugin/blob/master/src/main/java/org/honton/chas/exists/AbstractExistsMojo.java
lines 168 to 172:

return getRepositoryBase() + '/'
    + groupId.replace('.', '/') + '/'
    + artifactId.replace('.', '/') + '/' // IMHO replace() here is not needed.
    + version + '/'
    + artifact;
@zielezin
Copy link
Author

zielezin commented Sep 29, 2017

Hi Chonton,

0.0.5 worked like a charm.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant