Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.send() is not a function #63

Closed
sethvincent opened this issue Jun 21, 2016 · 3 comments
Closed

app.send() is not a function #63

sethvincent opened this issue Jun 21, 2016 · 3 comments

Comments

@sethvincent
Copy link
Contributor

In the readme the effects description implies that the app.send() method exists: https://github.com/yoshuawuyts/choo#appmodelobj

We should either revise that bit of the docs or attach send to app.

I found this writing some alternate link-catching code and wanted to send an action to update the state with the new location.

I was doing this just in an onclick event listener, but I could do it in a subscription, and that's probably the recommended approach, rather than needing app.send.

@yoshuawuyts
Copy link
Member

Hah yeah, the docs should be updated on that one; I'd rather not expose send() and state outside the application boundries, as it enables behavior that would break the pattern - going with subscriptions is def recommended here ✨

@sethvincent
Copy link
Contributor Author

👍 agreed

@yoshuawuyts
Copy link
Member

This should be fixed in the 3.0 docs - closing as release is imminent ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants