bankai v9.x.x issues

[sholtomaud]

Placeholder: I'm having a few issues installing a new electron app with the release candidate of v9. Once v9 of bankai reaches greater stability I suggest a review of the choo-electron app creation process. Specifically how to handle some of the chrome security https and http2 issues that I have found popping up.

[yoshuawuyts]

Hey, yeah agree — for now we've reverted the generator to use bankai 8. I think issues should be fairly straight forward to fix;
but the end game would probably be to allow bankai to boot up an Electron instance, and also know how to compile apps. Probably
requires a whole bunch of tweaking tho; but the end result would definitely be worth it I reckon! :D

[lejeunerenard]

Bankai v9 seems to be working for me from minimal testing and fixes. I tried creating a repo & then updating bankai to v9 and it worked once I addressed the https self-signed certificate issue.

I fixed the certificate issue by adding the following to my main.js:

app.on('certificate-error', (event, webContents, url, err, cert, cb) => {
  if (url.match('https://localhost')) {
    event.preventDefault()
    cb(true)
  } else {
    cb(false)
  }
})

This is using the certificate-error event for electron (source) to detect when a problem occurs. I just check to see if the domain is localhost and the protocol is https. This is probably not the safest but could work for a development environment to get past the self-signing issue.

I have yet to run into any http2 issues, but then again I don't really know much about it. 😅

[yoshuawuyts]

@lejeunerenard hahaha, wellll maybe if we wrap this in a process.env === 'development' clause, it might be great to include by default!