Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new binning type based on gain ratio #15

Closed
lucazav opened this issue Apr 14, 2020 · 3 comments
Closed

A new binning type based on gain ratio #15

lucazav opened this issue Apr 14, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@lucazav
Copy link

lucazav commented Apr 14, 2020

It'd be great if the binning() function had a type of binning based on gain ration maximization.
Here an example of the discretize_rgr() function implemented into the funModeling package.

@choonghyunryu
Copy link
Owner

@lucazav
Thanks for the great feature suggestion.
I will add the features you suggested to the next version.

@choonghyunryu choonghyunryu added the enhancement New feature or request label Aug 22, 2021
@choonghyunryu
Copy link
Owner

@lucazav,

To submit to CRAN, the number of imported packages must be less than 20. By the way, the binning you suggested is to add the import package. This makes it difficult to keep packages on CRAN. So I put off development.

However, I implemented the function today by putting that package, funModeling, as 'Suggests' rather than 'Imports'.

Sorry for the very late appointment.

The name of the function is binning_rgr().

@choonghyunryu
Copy link
Owner

I close the issue because I implemented that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants