Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Flutter 1.17.5 #29

Closed
Dinesh41 opened this issue Mar 24, 2021 · 7 comments
Closed

Not compatible with Flutter 1.17.5 #29

Dinesh41 opened this issue Mar 24, 2021 · 7 comments

Comments

@Dinesh41
Copy link

I need to use this plugin in Flutter 1.17.5.

If i upgrade to Flutter latest version and add this plugin. Version solving is failing due to other dependencies.

@chooyan-eng
Copy link
Owner

@Dinesh41 Thank you for your feedback. I’ll check this.

@chooyan-eng
Copy link
Owner

@Dinesh41
I have to inform you that this package uses dart 2.12.0 or above for Null Safety, and Flutter 2.0 is required to be installed into your PC.

If you have other dependency which is not available with Flutter 2.0 in your project, it means there is no way for me to solve the issue other than waiting for those packages applied to Null Safety as well.

Or, you can folk this project and rewrite the code in this package without Null Safety.

@rayliverified
Copy link

I needed the library non-null safe too.
I converted it in my fork https://github.com/searchy2/crop_your_image/tree/ray-nonnullsafe

Include it in your project with Git import:

  crop_your_image:
    git:
      url: git://github.com/searchy2/crop_your_image.git
      ref: ray-nonnullsafe

@chooyan-eng
Copy link
Owner

@searchy2
Thank you for forking and publish non-null safe version of crop_your_image!
I guess it would help @Dinesh41 and others who need this.

@chooyan-eng
Copy link
Owner

I'll close this issue as using searchy2's version would solve it.

@rayliverified
Copy link

Please refresh my memory but was there a reason why this library isn't being migrated to null safety?

If not, I should be able to submit a PR to make this library null safe.

@chooyan-eng
Copy link
Owner

chooyan-eng commented Aug 13, 2021

@searchy2
crop_your_image IS migrated to null safety since the very first version.
The issue here was that some needed "Non-null safe" version of crop_your_image because they were using older version of Flutter, and I'm not thinking of publishing that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants