Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Give ability to customize the loading indicator #56

Closed
ghost opened this issue Nov 30, 2021 · 3 comments
Closed

[PROPOSAL] Give ability to customize the loading indicator #56

ghost opened this issue Nov 30, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 30, 2021

Hi! It will be very good to have access to change the progress indicator.

Could you please add a new parameter to the Crop widget, so we can pass our custom progress indicator widget? Many thank in advance.

image

@vixez
Copy link

vixez commented Jan 10, 2022

I have this feature already in PR: #49

@chooyan-eng
Copy link
Owner

@PTLam25
Thank you for the feedback.

@vixez
Thank you for your PR! I'll check this.

@chooyan-eng
Copy link
Owner

I just added progressIndicator parameter to Crop class. You can check the change in #75 .

@vixez
I checked your PR and I could make the PR above using your idea. I didn't merge your PR as is but I separated "loading widget" part into #75 and fixed param name and how default widget is set. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants