Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on interactive mode #82

Open
gmarizy opened this issue Dec 20, 2022 · 1 comment · May be fixed by #92
Open

Feedback on interactive mode #82

gmarizy opened this issue Dec 20, 2022 · 1 comment · May be fixed by #92
Labels
need fix Issues that @chooyan-eng need to do something

Comments

@gmarizy
Copy link

gmarizy commented Dec 20, 2022

I use Crop in interactive: true, fixArea: true mode. It work great, but encountered two situations where API wasn't adequate with interactive mode:

  • No equivalent of onMove; couldn't detect when user started to interact with crop widget. Use case: I wanted to display a hint animation on usage, that should disappear when user start using crop widget.
  • In interactive crop one could want to replace the four dot overlay with something more adapted to interactive mode. The parameter to customize the 4 dots overlays, cornerDotBuilder, don't support that. I managed to synchronize initialAreaBuilder and a custom overlay on top of Crop, but it's not ideal.

It's less an issue than a feedback, and it surmontable, but thought it was worth reporting.

@eidolonFIRE
Copy link

Proposed fix for your first bullet point. I hit the same issue.
#92

@eidolonFIRE eidolonFIRE linked a pull request Feb 26, 2023 that will close this issue
@chooyan-eng chooyan-eng added the need fix Issues that @chooyan-eng need to do something label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need fix Issues that @chooyan-eng need to do something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants