(#526) Handle the exitcode of a still running task correctly

This sets the exit code to -1 for still running tasks or tasks
that never started, handles -1 in the app to correctly record running
tasks

lib/mcollective/application/tasks.rb

@@ -299,7 +299,7 @@ def request_and_report(action, arguments, taskid=nil) # rubocop:disable Metrics/
           if reply[:statuscode] == 3
             fail_nodes += 1
             task_not_known_nodes += 1
-          elsif status[:exitcode] == 0
+          elsif [-1, 0].include?(status[:exitcode])
             status[:completed] ? completed_nodes += 1 : running_nodes += 1
             runtime += status[:runtime]
             reply[:statuscode] == 0 ? success_nodes += 1 : fail_nodes += 1

lib/mcollective/util/tasks_support.rb

@@ -440,7 +440,7 @@ def task_status(requestid)
           "caller" => nil,
           "stdout" => "",
           "stderr" => "",
-          "exitcode" => 127,
+          "exitcode" => -1,
           "runtime" => task_runtime(requestid),
           "start_time" => Time.at(0).utc,
           "wrapper_spawned" => false,

spec/unit/mcollective/util/tasks_support_spec.rb

@@ -190,7 +190,7 @@ module Util
             "spool" => spool,
             "stdout" => ts.create_task_stdout("", true, 127, err),
             "stderr" => "",
-            "exitcode" => 127,
+            "exitcode" => -1,
             "runtime" => 0.0,
             "wrapper_spawned" => false,
             "wrapper_error" => err,
@@ -215,7 +215,7 @@ module Util
             "spool" => spool,
             "stdout" => stdout,
             "stderr" => "",
-            "exitcode" => 127,
+            "exitcode" => -1,
             "runtime" => 10,
             "wrapper_spawned" => true,
             "wrapper_error" => "",