(#523) support max_reconnect_attempts for the NATS connection

On clients the behaviour of never ending reconnects is a problem when
running some client in an automation since you might end up getting
stuck forever in a loop should the configuration be incorrect

This allows setting plugin.nats.max_reconnect_attempts to a integer
setting, it defaults to -1 as today

Rakefile

@@ -62,7 +62,7 @@ task :update_ddl do
   require "mcollective"
 
   Dir.glob("lib/mcollective/agent/*.ddl") do |ddlfile|
-    next if ddlfile =~ /^choria_uril/
+    next if ddlfile =~ /^choria_util/
 
     agent_dir = File.dirname(ddlfile)
     agent_name = File.basename(ddlfile, ".ddl")

lib/mcollective/connector/nats.rb

@@ -68,7 +68,7 @@ def connect
         end
 
         parameters = {
-          :max_reconnect_attempts => -1,
+          :max_reconnect_attempts => Integer(get_option("nats.max_reconnect_attempts", "-1")),
           :reconnect_time_wait => 1,
           :dont_randomize_servers => !choria.randomize_middleware_servers?,
           :name => @config.identity,

spec/unit/mcollective/connector/nats_spec.rb

@@ -85,6 +85,28 @@ module MCollective
         connector.connect
       end
 
+      it "should support setting maximum reconnects" do
+        Config.instance.stubs(:pluginconf).returns("nats.max_reconnect_attempts" => "10")
+        mock_context = OpenSSL::SSL::SSLContext.new
+        choria.stubs(:ssl_context).returns(mock_context)
+        choria.expects(:randomize_middleware_servers?).returns(true)
+
+        connector.connection.expects(:start).with(
+          :max_reconnect_attempts => 10,
+          :reconnect_time_wait => 1,
+          :dont_randomize_servers => false,
+          :name => "rspec_identity",
+          :tls => {
+            :context => mock_context
+          },
+          :servers => ["nats://puppet:4222"]
+        )
+
+        choria.expects(:check_ssl_setup)
+
+        connector.connect
+      end
+
       it "should connect" do
         mock_context = OpenSSL::SSL::SSLContext.new
         choria.stubs(:ssl_context).returns(mock_context)