This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
(#518) valid_certificate?: use OpenSSL::X509::Store for checking certificates #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-gozdek-sociomantic
force-pushed
the
ca-bundle
branch
from
e10cd0d
to
6787607
Compare
|
Neat. Mind opening a ticket for this etc as per the contribution guides? |
mateusz-gozdek-sociomantic
force-pushed
the
ca-bundle
branch
from
6787607
to
62a0d73
Compare
mateusz-gozdek-sociomantic
changed the title
Done. Sorry, I rushed a little bit with a PR :) |
…checking certificates Instead of OpenSSL::X509::Certificate, as Store allows for validation against CA bundle, which is required when you roll new CA certificate. Closes choria-legacy#518
mateusz-gozdek-sociomantic
force-pushed
the
ca-bundle
branch
from
62a0d73
to
6b357d7
Compare
|
Updated to use |
|
thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of OpenSSL::X509::Certificate, as Store allows for validation
against CA bundle, which is required when you roll new CA certificate.
I am not sure if this is wanted behaviour, but it seems to work when you have multiple certificates in
ca.pemfile.Closes #518