This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
(#623) Print CSR fingerprint in request_cert application #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, mind opening an issue and using the correct commit line? Kind of moving to |
With this change, the fingerprint of the CSR is print to the user when running `mco choria request_cert`. This fingerprint is also shown when running `puppetserver ca list`, the idea is to make it easy to check the requests match on both sides when new users are enrolled and we try to teach them best practices. Sample output: ```sh-session romain@marvin /tmp $ USER=bob mco choria request_cert --config client.cfg Certificate /tmp/ssl/certs/bob.mcollective.pem has already been requested, attempting to retrieve it Waiting up to 240 seconds for it to be signed Key fingerprint: (SHA256) 44:84:F4:F8:88:7B:E4:97:9C:47:B6:3A:E1:36:C2:C6:D0:FF:DA:A9:23:B9:5D:62:74:C3:8D:3C:0C:1D:ED:FA Attempting to download certificate /tmp/ssl/certs/bob.mcollective.pem: 0 / 24 ```
|
Done! |
ripienaar
changed the title
|
thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the fingerprint of the CSR is print to the user when
running
mco choria request_cert.This fingerprint is also shown when running
puppetserver ca list, theidea is to make it easy to check the requests match on both sides when
new users are enrolled and we try to teach them best practices.
Sample output: