Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor Integration #9

Open
WhatsThatItsPat opened this issue Jul 25, 2018 · 2 comments
Open

Capacitor Integration #9

WhatsThatItsPat opened this issue Jul 25, 2018 · 2 comments

Comments

@WhatsThatItsPat
Copy link

Have you looked into Capacitor while considering this project? In particular, there are two APIs you might want to look at.

  • App, which allows you to addListener to the appUrlOpen event, which will replace (<any>window).handleOpenURL.
  • Browser, which will replace cordova-plugin-browsertab.

Creating a Capacitor plugin could also be considered. Perhaps AppAuth-iOS and AppAuth-Android SDKs could both be leveraged in this scenario as in React Native App Auth.

@wi3land
Copy link
Collaborator

wi3land commented Jul 26, 2018

Capacitor does state that it only uses safaribrowser controller when on IOS, we kind of want it to inappbrowser when there is absolutely no other choice as it is no longer recommended as a solution for OAuth guidelines.

I have been tinkering around with a cordova plugin for Appauth using the native IOS and Android but it is a long way off at this point.

@WhatsThatItsPat
Copy link
Author

WhatsThatItsPat commented Jul 26, 2018

Capacitor doesn't preclude the use of Cordova, so InAppBrowser could probably still be used. For my use case, I don't mind requiring users to have iOS9 / SafariViewController without the fallback to InAppBrowser.

Since Capacitor seems to be the future of Ionic, I would think it to be the best way forward. The Capacitor documents lead me to believe it's an easier development path than Cordova as well.

Perhaps @mlynch can offer some insight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants