Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloca.h is not standard #5

Closed
aameen951 opened this issue Jan 18, 2017 · 5 comments
Closed

alloca.h is not standard #5

aameen951 opened this issue Jan 18, 2017 · 5 comments

Comments

@aameen951
Copy link

../code/twitter.c(5): fatal error C1083: Cannot open include file: 'alloca.h': No such file or directory

@chr-1x
Copy link
Owner

chr-1x commented Jan 18, 2017

I'm aware it's nonstandard, but what compiler + version is this?

@aameen951
Copy link
Author

Im using MSVC 2015

@chr-1x
Copy link
Owner

chr-1x commented Jan 18, 2017

Ah, this must be due to the change I just pushed. Seems MSVC and GCC/Clang provide it in different headers. I'll add a guard to check compiler version there. At the moment alloca is used several places where I don't have good alternatives that fit within my API constraints, so it's necessary to keep around.

@aameen951
Copy link
Author

in MSVC it is already included in malloc.h _alloca

you can wrap the include with ifndef _MSC_VER

@chr-1x
Copy link
Owner

chr-1x commented Jan 18, 2017

This is done and committed. Thanks for the feedback!

@chr-1x chr-1x closed this as completed Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants