Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Lyrics error for opus files although all settings for lyrics are DISABLED #30

Closed
klawdhfzasjhaa opened this issue Sep 21, 2022 · 7 comments
Labels
Bug Bugs. Crashes or something isn't working

Comments

@klawdhfzasjhaa
Copy link

Describe the bug or unexpected behavior
When I play a song, I get a message: "Failed to read lyrics from song
No Reader associated with this extension:opus". I have disabled all settings regarding lyrics. The app should respect those settings and not show an error message.

Crash log
Crash Report:

Package name: player.phonograph.plus
App version: 0.3.3 (311)
Git Commit Hash: fec2284
Android version: 12 (SDK 32)
Device brand: not important
Device model: not important
Product name: lineage_ABC
Build version: lineage_ABC-userdebug 12
Hardware: qcom
Language: it

Failed to read lyrics from song
No Reader associated with this extension:opus

@klawdhfzasjhaa klawdhfzasjhaa added the Bug Bugs. Crashes or something isn't working label Sep 21, 2022
@chr56
Copy link
Owner

chr56 commented Sep 21, 2022

Sorry for that, Phonograph Plus currently can not handle opus files properly — it can not read its tag (See #9 ).

And Phonograph will automatically try to search lyrics (external or embedded in song tags), however pitifully, there isn't a switch to turn off this "automatically lyrics-fetching".

(So, you can see this error message because Phonograph Plus is trying to search this song's lyrics and since it can't find external lyrics (file <SONG_FILE_NAME>.lrc) it try to reading tags for embedded lyrics, so, that's the time error message popup)

I can temperately block the message until solving the opus files problem in next version. (And maybe add a switch to turn off lyrics searching & loading as well)

@chr56
Copy link
Owner

chr56 commented Sep 21, 2022

BTW, the reading opus files tags problem might be done in earlier time of next year or end of this year.

@klawdhfzasjhaa
Copy link
Author

Thank you. I disabled the error notifications for Phonograph Plus for now.

@chr56
Copy link
Owner

chr56 commented Sep 22, 2022

Mute this error notification in commit 030abe75d71f

@chr56
Copy link
Owner

chr56 commented Sep 22, 2022

Phonograph Plus Preview Version

For test

@klawdhfzasjhaa You can enable error notifications now to test it.

@klawdhfzasjhaa
Copy link
Author

Works! :)

@chr56
Copy link
Owner

chr56 commented Oct 3, 2022

close!
fixed in v0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs. Crashes or something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants