Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can not change grid size of lists on large tablet devices #46

Closed
Bejukoro opened this issue Nov 13, 2022 · 11 comments
Closed

[Bug]: Can not change grid size of lists on large tablet devices #46

Bejukoro opened this issue Nov 13, 2022 · 11 comments
Labels
Bug Bugs. Crashes or something isn't working

Comments

@Bejukoro
Copy link

Bug Summary

平板设备上,横屏时歌曲列表的网格尺寸被固定在6,无法修改
选择其它网格尺寸时不会生效,尺寸依然是6
(在手机上横屏时未发现此问题,可以正常修改网格尺寸)

Version

0.4.1

Steps to reproduce the bug

No response

Screenshots or Screen recordings

Screenshot_20221113-091707_Phonograph Plus
Screenshot_20221113-091715_Phonograph Plus

Environment

Mi Pad 5 (nabu)
ArrowOS 13.0 (Android 13)

Other helpful information

No response

@Bejukoro Bejukoro added the Bug Bugs. Crashes or something isn't working label Nov 13, 2022
@chr56
Copy link
Owner

chr56 commented Nov 13, 2022

???

可以的话,把设置导出,然后把json内容发出来看看

@Bejukoro
Copy link
Author

???

可以的话,把设置导出,然后把json内容发出来看看

{ "fixed_tab_layout": false, "SHUFFLE_MODE": 1, "classic_notification": false, "last_added_interval": "past_seven_days", "REPEAT_MODE": 0, "broadcast_current_player_state": true, "use_legacy_list_files_impl": false, "POSITION": 0, "should_color_app_shortcuts": true, "synchronized_lyrics_send": true, "use_legacy_favorite_playlist_impl": false, "last_start_page": 0, "general_theme": "auto", "ignore_media_store_artwork": true, "remember_shuffle": true, "remember_last_tab": true, "blurred_album_art": false, "album_art_on_lockscreen": true, "keep_playing_queue_intact": true, "POSITION_IN_TRACK": 65351, "synchronized_lyrics_show": true, "audio_ducking": true, "check_upgrade_at_startup": true, "colored_notification": true, "playlist_files_operation_behaviour": "auto", "auto_download_images_policy": "never", "intro_shown": true, "song_sort_mode": "song_name:0", "use_legacy_detail_dialog": false, "enable_lyrics": true, "song_grid_size": 2, "gapless_playback": false, "song_colored_footers": true, "display_lyrics_time_axis": true, "initialized_blacklist": true, "last_changelog_version": 401 }

@Bejukoro
Copy link
Author

???

可以的话,把设置导出,然后把json内容发出来看看

对比了在手机上导出的 json 文件后,我在平板上导出的 json 文件中加上了 "song_grid_size_land": 3 这一行,然后导入回应用中。
此时横屏时的网格尺寸成功变成了 3,但是依然无法通过对应选项进行修改,选择其他选项后横屏网格尺寸也会保持在 3。

@chr56
Copy link
Owner

chr56 commented Nov 13, 2022

对比了在手机上导出的 json 文件后,我在平板上导出的 json 文件中加上了 "song_grid_size_land": 3 这一行,然后导入回应用中。 此时横屏时的网格尺寸成功变成了 3,但是依然无法通过对应选项进行修改,选择其他选项后横屏网格尺寸也会保持在 3。

那么,就是新设置保存不了,可能是UI问题,保存不了新值,但是就只在平板出现,就挺诡异。

等我再检查一下源码...

@chr56
Copy link
Owner

chr56 commented Nov 13, 2022

问题已在模拟器上复现,应该是平板(sw600dp,短边大于600dp设备)特有的. @Bejukoro

@chr56
Copy link
Owner

chr56 commented Nov 13, 2022

已于 db758a0 修复

@chr56 chr56 added the Closing The issue was done and would be closed soon label Nov 13, 2022
@chr56
Copy link
Owner

chr56 commented Nov 13, 2022

Preview 通道: (包名player.phonograph.plus.preview)
Phonograph_Plus_0.5_dev1_db758a0e7.zip

@Bejukoro 你再试试这个

@chr56 chr56 changed the title [Bug]: 在平板设备上,横屏时歌曲列表的网格尺寸被固定在6,无法修改 [Bug]: Can not change grid size of lists on large tablet devices Nov 13, 2022
@Bejukoro
Copy link
Author

Preview 通道: (包名player.phonograph.plus.preview) Phonograph_Plus_0.5_dev1_db758a0e7.zip

@Bejukoro 你再试试这个

已修复,感谢 👍

@chr56
Copy link
Owner

chr56 commented Nov 13, 2022

已修复,感谢 👍

如果顺利的话,0.5.0应该能在这个月发布

@Bejukoro
Copy link
Author

已修复,感谢 👍

如果顺利的话,0.5.0应该能在这个月发布

辛苦了 🙆

@chr56
Copy link
Owner

chr56 commented Nov 27, 2022

Closed, due to release of v0.5.0

@chr56 chr56 closed this as completed Nov 27, 2022
@chr56 chr56 removed the Closing The issue was done and would be closed soon label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs. Crashes or something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants