Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of empty special tiles sometimes results in visual artifacts #192

Open
chrahunt opened this issue Jul 8, 2017 · 1 comment
Open
Labels

Comments

@chrahunt
Copy link
Owner

chrahunt commented Jul 8, 2017

As mentioned in #191 and here, when using this tile texture, there are small bars visible beneath empty bomb tiles and empty flag tiles. Example:

screencap of tagpro game with single-pixel wide colored bar appearing beneath empty bomb tiles

The top of the tile in the row below these tiles in the sprite images are getting picked up somehow. I checked the y offset of the files below empty bomb and empty flag in that texture pack and they are correct (120).

@chrahunt chrahunt added the bug label Jul 8, 2017
@chrahunt
Copy link
Owner Author

chrahunt commented Jul 8, 2017

It looks like the artifact only appears when the fractional part of y > 0.5, so it may be some anti-aliasing effect that merges adjacent pixels from the source image with the existing destination pixels. Having an intermediate representation that only includes the images (like drawing the images in isolation to their own offscreen canvases) and sourcing from that should fix it. It may also be better to transition to something like Pixi, which will clean up a lot of the rendering code and allow re-use of parts of the TagPro renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant