-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing zlib #23
Comments
I plan to switch to system zlib when I'm no longer frequently updating the codebase. For now, the likelihood that statically-linked zlib 1.2.8 will have higher performance than the system-installed version is too high. The plink_first_compile script downloads zlib 1.2.8 into the current directory. |
Thanks for pointing out a workaround. I don't quite understand your point about zlib -- can you elaborate?. Is the issue that common platforms come with an older version (e.g., CentOS 7 comes with 1.2.7)? I don't see how static vs dynamics linking would make a difference in performance. If you need a statically-linked version, CentOS 7 has packages for both statically and dynamically linked versions of zlib -- maybe other platforms do as well? |
Yes, the issue is that plink is used on a bunch of systems with much older zlibs, and it is sometimes a pain for the users to get a newer version installed. |
Makes sense! Thanks! |
The Makefile appears to assume that the zlib library is located in the current directory
It seems it might be better to use the system's zlib library.
The text was updated successfully, but these errors were encountered: