Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces in Imports field not imported from #18

Closed
edzer opened this issue Feb 13, 2019 · 4 comments
Closed

Namespaces in Imports field not imported from #18

edzer opened this issue Feb 13, 2019 · 4 comments

Comments

@edzer
Copy link

edzer commented Feb 13, 2019

When I run R CMD check on the package, I see

* checking dependencies in R code ... NOTE
Namespaces in Imports field not imported from:lwgeom’ ‘tibble

suggesting that these two packages can be removed from Imports:
openjournals/joss-reviews#1221

@chris-prener
Copy link
Owner

Thanks @edzer - we want to make sure lwgeom is installed because we use sf::st_area in the package. So while we don't import anything directly, it is a necessary dependency that isn't installed automatically by sf. At least that is how I am thinking about it - am I off base there?

With tibble - my understanding is that if a package prints an object as a tibble but the user does not have tibble installed, there are issues with printing the object. So therefore safter to require tibble as a dependency? Again, would love your perspective here.

Thanks for the feedback!

@edzer
Copy link
Author

edzer commented Feb 15, 2019

st_area is in sf, and sf only class lwgeom stuff if the data are in geodetic coordinates, which is often not the case, so you don't actually need it, and sf will tell you when you need it. tibble is a dependency of dplyr, so comes automatically when you import dplyr.

If CRAN has no problems with what you do, then I also don't.

@chris-prener
Copy link
Owner

We put it in when we were testing the package and were prompted to install lwgeom by sf. I'll revisit whether it is necessary, though. CRAN had no problems.

@chris-prener
Copy link
Owner

have removed lwgeom (shouldn't be needed since projected coords required by functions) and tibble (which should be installed along with dplyr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants