Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Commit

Permalink
Safari: minor code fix
Browse files Browse the repository at this point in the history
  • Loading branch information
@chrisaljoudi
chrisaljoudi committed Mar 31, 2015
1 parent 91c2d95 commit 6850fa0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion platform/safari/vapi-background.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@
/******************************************************************************/

vAPI.isNoTabId = function(tabId) {
return tabId.toString() === '-1';
return tabId.toString() === this.noTabId;
};

vAPI.noTabId = '-1';
Expand Down

34 comments on commit 6850fa0

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the commit here, just the only way I could think to reach both of you.

@Deathamns / @chrisaljoudi

Any one of you (or both) willing to take over this whole project?

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill I'd be happy to do it. Is there something wrong, or are you simply running out of patience/time?

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisaljoudi is there a way to move everything to your repo, including issues?

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill yes; settings:

settings button

then scroll down, transfer ownership:

transfer ownership

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Looks like this has to be confirmed by someone at Github to complete.

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill okay, seems to have taken effect.

What would you like to do about the Chrome Web Store?

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you should publish new version with a name indicative of the change. I plan to work on my own version which may or may not diverge from the current official version, so should the two versions diverge enough, keeping my own version on Chrome store is a good thing.

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill okay. Would you mind requesting the transfer here? That'll ensure that current users can get updates.

Email is chris@chrismatic.io.

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, I prefer to keep the Chrome store version as my own version. Publish a new version please.

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill got it; sorry. Will do.

@gorhill
Copy link
Contributor

@gorhill gorhill commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove me as collaborator of the project please? Thanks.

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill done.

April Fools', by any chance?

@Deathamns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill Reasons?

@my-password-is-password
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @gorhill

👍

@Betsy25
Copy link

@Betsy25 Betsy25 commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the wonderful project @gorhill 👍
*Silently hoping for some contribution now & then"

@Deathamns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisaljoudi Remove me too from collaborators, please.

Edit: Never mind, I was able to do it...

@SW1FT
Copy link
Contributor

@SW1FT SW1FT commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill Who is going to maintain the Firefox version of uBlock?

@Nocturnalizer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an utterly strange sequence of events. Within hours, two of the main contributors drop off with no reason given. Weird! @Deathamns and @gorhill did a superb job anyway, irrespective of their reasons for leaving.

@Betsy25
Copy link

@Betsy25 Betsy25 commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least a small reason was the least people should expect.
Oh well, whatever, wish Chris all the luck, and hopefully skilled devs for platforms other than Safari will show up.

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Betsy25 hope so, too. I'm comfortable with the Safari and Chrome extension APIs, but not really with Firefox.

Will have to see how things turn out.

@neurodiverseEsoteric
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisaljoudi
About your last comment; is this the general view of all web developers nowadays? Is this why all of the best extensions for Firefox stopped getting support and/or updates? I've seen a really high increase of addons that are stuck in 2013, and a subsequent sharp drop in their ratings, deservedly. So is it safe to say the world has pulled the plug on our poor fox?
Thing is, I will never use any browser that comes with permanently un-removable "auto"-anything features. Firefox was the only trustworthy browser that I could tell to not forcibly record or change what I typed, especially on the address bar. However, extensions like these, the only safety equipment available for the internet, the only protection from the "bad guys" that still allowed some visibility as well as access into the proverbial "outside cyber-world," they are being thrown away for no good reason, as far as I can tell.
Why not stop beating about the bush, and axe every undersea networking cable, bomb every tier-1 ISP storage and server sites, and return to the world of the previous millennium? At least there we could still have information, advertising, and crime as separate, let alone omnipresent, entities which waltzed about in our world.

@raptantahj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisaljoudi @gorhill @Deathamns Can we get some more information on this leadership change? This seems like a strange set of circumstances.

@DomT4
Copy link

@DomT4 DomT4 commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the "official" advice on which version we should be using now?

@neurodiverseEsoteric
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlu1024 : I'm not a web developer or a programmer. I have no idea who else or where else, let alone how else, to ask about this web-crisis. If there even has been a declaration of a "web-crisis," that is.

@SW1FT
Copy link
Contributor

@SW1FT SW1FT commented on 6850fa0 Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DomT4 I suggest sticking with Gorhill's version if you're using Chromium browsers because he is the creator. However, if you happen to use Safari, I suggest sticking with this version by Chris.

@chrisaljoudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SW1FT @DomT4 whichever you feel like — I just don't know what gorhill will be changing in his private version (or whether it's meant for public usage at all).

As a side note, I'd like to point out that all new features/updates are going to be made to this main project and will be included for Chromium as well.

In other words, Chromium development is for sure remaining active here.

@ItzBlitz98
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to thank you @gorhill for all the work you have done.

@rodalpho
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thank you @gorhill!

And please do let us know why you dropped out so suddenly, hope everything is OK.

@sammcj
Copy link

@sammcj sammcj commented on 6850fa0 Apr 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's not a joke - 'official' explanation here: http://www.wilderssecurity.com/threads/ublock-a-lean-and-fast-blocker.365273/page-33#post-2476324

@TteokbokkiNari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sammcj That link is much appreciated. Sad to hear it weighted down on him this hard.

@jasonmit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, what a great thing you've all created. Sorry to see you all leaving the project.

Thanks for all the fish 👍

@harshanvn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its sad to see @gorhill @Deathamns leave. I wish all the best for their future endeavors.

Its really amazing that gorhill created this wonderful extension (in a short span of time), and set a bar quite high on how an extension should be :) . Really i cannot live with out this extension!!

I hope all the fixes/enhancements gorhill make in the future for his branch, will come down to this firefox version..

Again, thanks to all the Dev Trio for your effort and contributions :).

All the Best @chrisaljoudi for your new role and responsibility. Thanks for your continued support.

@Flashwalker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can't understand the reason of diverge.
@gorhill says

because of serious incompatibilities in the spirit of the project.

and this
and stoped contributing here.
Just looks like somewhat disappointment in...
In what?
Coding? Spiritless Devs? Or all the people? Or etc.
Actually it's still utterly strange sequence of events and strange set of circumstances.

Please sign in to comment.