Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Candidate for fix for #1140 #1150

Merged
merged 8 commits into from Apr 7, 2015
Merged

Candidate for fix for #1140 #1150

merged 8 commits into from Apr 7, 2015

Conversation

AlexVallat
Copy link
Contributor

As described in gorhill/uBlock#1140 (comment), this is a work around for Firefox sending document-element-inserted before nsIWebProgressListener.onLocationChange. It would, however, mean that we will usually get two location changes for the same page.

…f onLocationChange occurring before document-element-inserted
@gorhill
Copy link
Contributor

gorhill commented Apr 2, 2015

@AlexVallat
Copy link
Contributor Author

Yes, that's me, why?

@gorhill
Copy link
Contributor

gorhill commented Apr 2, 2015

Do you want to take over the add-on on Firefox?

@AlexVallat
Copy link
Contributor Author

Is @Deathamns leaving? That's bad news! I've just noticed you transferred the project to @chrisaljoudi too, wow.

OK, well, I'll certainly do my best to maintain the Firefox bits, although my time becomes more limited after the Easter holidays finish.

How do you want to handle the AMO listing - do you want me to maintain that, or is @chrisaljoudi already doing that as part of the build process?

@gorhill
Copy link
Contributor

gorhill commented Apr 2, 2015

do you want me to maintain that

That would be best, as you worked on the Firefox-specific code. What e-mail do I use to add you as a manager?

@AlexVallat
Copy link
Contributor Author

My AMO account email is -edit removed-, thanks

@chrisaljoudi: When you get a few minutes, we should talk about build and deployment processes, and see how much automation can be achieved. Also, what sort of dev release / blessed release system you want to use - once it's fully reviewed we can push out a faster release developer channel as well as reviewed full releases.

@AlexVallat
Copy link
Contributor Author

On reflection, this is not really the right place to discuss this, so I've created an issue for it: #1166

Returning briefly to topic - If @Deathamns is no longer participating, then I guess code review for this is up to @chrisaljoudi now, perhaps when things calm down a bit!

@AlexVallat AlexVallat mentioned this pull request Apr 6, 2015
chrisaljoudi added a commit that referenced this pull request Apr 7, 2015
@chrisaljoudi chrisaljoudi merged commit 738c695 into uBlock-LLC:master Apr 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants