Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shown even though up to date #299

Closed
arogl opened this issue Jun 10, 2022 · 7 comments
Closed

Update shown even though up to date #299

arogl opened this issue Jun 10, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@arogl
Copy link

arogl commented Jun 10, 2022

I just installed 1.3.20 and when starting get the below

image

@chrisant996
Copy link
Owner

Thanks for reporting this. I'll take a look.

Can you make it happen again, and then upload the clink.log file here?

@arogl
Copy link
Author

arogl commented Jun 10, 2022

5aa0 start_logger              154 ---- 2022/06/10 15:31:09.097 -------------------------------------------------
5aa0 start_logger              160 Host process is 'cmd.exe' (pid 23200)
5aa0 start_logger              164 DLL path is 'C:\Program Files (x86)\clink'
5aa0 start_logger              178 Windows version 10.0.19044 (x64)
5aa0 start_logger              181 Clink version 1.3.20.59deed (x64)
5aa0 hook_setter::hook_setter  156 >>> Started hook transaction.
5aa0 hook_setter::attach_iat   313 Attempting to hook SetEnvironmentVariableW in IAT for module 00007FF71ECC0000.
5aa0 pe_info::iterate_imports  159 Found import in 'api-ms-win-core-processenvironment-l1-1-0.dll'
5aa0 find_iat                  121 Found import at 00007FF71ECF3860 (value is 00007FF942F2C540).
5aa0 hook_setter::attach_iat   313 Attempting to hook WriteConsoleW in IAT for module 00007FF71ECC0000.
5aa0 pe_info::iterate_imports  159 Found import in 'api-ms-win-core-console-l1-1-0.dll'
5aa0 find_iat                  121 Found import at 00007FF71ECF34F8 (value is 00007FF942ED1630).
5aa0 hook_setter::attach_iat   313 Attempting to hook GetEnvironmentVariableW in IAT for module 00007FF71ECC0000.
5aa0 pe_info::iterate_imports  159 Found import in 'api-ms-win-core-processenvironment-l1-1-0.dll'
5aa0 find_iat                  121 Found import at 00007FF71ECF3880 (value is 00007FF942EEABD0).
5aa0 hook_setter::commit       204 <<< Hook transaction committed.
5aa0 hook_setter::hook_setter  156 >>> Started hook transaction.
5aa0 hook_setter::detach_iat   356 Attempting to unhook 00007FF8E8B496A0 from GetEnvironmentVariableW in IAT for module 00007FF71ECC0000.
5aa0 pe_info::iterate_imports  159 Found import in 'api-ms-win-core-processenvironment-l1-1-0.dll'
5aa0 find_iat                  121 Found import at 00007FF71ECF3880 (value is 00007FF8E8B496A0).
5aa0 hook_setter::commit       204 <<< Hook transaction committed.
5aa0 hook_setter::hook_setter  156 >>> Started hook transaction.
5aa0 hook_setter::attach_iat   313 Attempting to hook ReadConsoleW in IAT for module 00007FF71ECC0000.
5aa0 pe_info::iterate_imports  159 Found import in 'api-ms-win-core-console-l1-1-0.dll'
5aa0 find_iat                  121 Found import at 00007FF71ECF34E0 (value is 00007FF942FC2BB0).
5aa0 hook_setter::commit       204 <<< Hook transaction committed.
5aa0 hook_setter::hook_setter  156 >>> Started hook transaction.
5aa0 hook_setter::attach_iat   313 Attempting to hook SetConsoleTitleW in IAT for module 00007FF71ECC0000.
5aa0 pe_info::iterate_imports  159 Found import in 'api-ms-win-core-console-l2-2-0.dll'
5aa0 find_iat                  121 Found import at 00007FF71ECF3558 (value is 00007FF942F3F490).
5aa0 hook_setter::commit       204 <<< Hook transaction committed.
5aa0 win_screen_buffer::begin  228 Using native terminal support; found 'Windows build >= 15063, console V2'.
5aa0 host_lua::load_scripts    138 Loaded 0 Lua scripts in 0 ms
5aa0 =?                          0 Clink updater: too soon to check for updates (1654833227 vs 1654839070).
5aa0 reset_handle              144 resetting mismatched stdout handle
5aa0 history_db::initialise   1249 master bank ctag: |CTAG_1616399996_110085875_163308_0
5aa0 history_db::compact      1494 History:  2696 active, 1363 deleted
5aa0 history_db::compact      1494 History:  2695 active, 1364 deleted
5aa0 reset_handle              144 resetting mismatched stderr handle
5aa0 history_db::compact      1494 History:  2694 active, 1365 deleted
C:\>clink set
autosuggest.async                 True
autosuggest.enable                True
autosuggest.original_case         True
autosuggest.strategy              match_prev_cmd history completion
clink.autostart
clink.autoupdate                  True
clink.colorize_input              True
clink.default_bindings            windows
clink.gui_popups                  False
clink.logo                        full
clink.paste_crlf                  crlf
clink.path
clink.promptfilter                True
clink.update_interval             5
cmd.admin_title_prefix
cmd.altf4_exits                   True
cmd.auto_answer                   off
cmd.ctrld_exits                   True
cmd.get_errorlevel                True
color.arg                         bold
color.arginfo                     yellow
color.argmatcher                  sgr 1;38;5;40
color.cmd                         bold
color.cmdredir                    bold
color.cmdsep                      bold
color.comment_row                 bright white on cyan
color.description                 bright cyan
color.doskey                      bold cyan
color.executable                  sgr 38;5;32
color.filtered                    bold
color.flag                        default
color.hidden                      sgr 38;5;160
color.horizscroll                 sgr 38;5;16;48;5;30
color.input                       sgr 38;5;222
color.interact                    bold
color.message                     default
color.modmark
color.popup
color.popup_desc
color.prompt
color.readonly                    sgr 38;5;28
color.selected_completion         sgr 38;5;16;48;5;254
color.selection                   sgr 38;5;16;48;5;179
color.suggestion                  bright black
color.unexpected                  default
color.unrecognized                sgr 38;5;203
debug.log_terminal                False
directories.dupe_mode             Controls how the current directory history is updated.  A value of 'add' (the
default) always adds the current directory to the directory history.  A value
of 'erase_prev' will erase any previous entries for the current directory and
then add it to the directory history.
Note that directory history is not saved between sessions.add
doskey.enhanced                   True
exec.aliases                      True
exec.commands                     True
exec.cwd                          True
exec.dirs                         True
exec.enable                       True
exec.files                        False
exec.path                         True
exec.space_prefix                 True
files.hidden                      True
files.system                      False
history.dont_add_to_history_cmds  exit history
history.dupe_mode                 erase_prev
history.expand_mode               not_quoted
history.ignore_space              True
history.max_lines                 25000
history.save                      True
history.shared                    False
history.sticky_search             False
history.time_format               %F %T
history.time_stamp                off
lua.break_on_error                False
lua.break_on_traceback            False
lua.debug                         False
lua.path
lua.reload_scripts                False
lua.strict                        True
lua.traceback_on_error            False
match.expand_envvars              True
match.fit_columns                 True
match.ignore_accent               True
match.ignore_case                 relaxed
match.max_fitted_matches          0
match.max_rows                    0
match.preview_rows                5
match.sort_dirs                   with
match.substring                   True
match.translate_slashes           system
match.wild                        True
prompt.async                      True
prompt.transient                  off
readline.hide_stderr              False
terminal.adjust_cursor_style      True
terminal.differentiate_keys       False
terminal.east_asian_ambiguous     auto
terminal.emulation                auto
terminal.mouse_input              auto
terminal.mouse_modifier
terminal.raw_esc                  False
terminal.use_altgr_substitute     False

image

@chrisant996
Copy link
Owner

Oh, I see what happened. Clink gets confused if an update has already been downloaded in the background, and then the same (or newer) version of Clink gets manually installed. Then it has a zip file downloaded and ready to go, so it says "update available". But then later clink update correctly realizes there's actually nothing to do. I'll fix that this weekend.

In the meantime, you can delete del %TEMP%\clink\updater\*.zip to make it stop saying there's an update available.

@chrisant996 chrisant996 added the bug Something isn't working label Jun 10, 2022
@arogl
Copy link
Author

arogl commented Jun 10, 2022

What is the recommended way to update clink?

I normally download the install in case of re-install later

@chrisant996
Copy link
Owner

Well, starting in v1.3.18 Clink has a built in updater.

So that would be the recommended way of updating, now.

There's nothing wrong with also updating other ways, but there's currently a bug where if you haven't disabled the built in updater but you manually update instead of using the built in updater, then the built in updater gets confused into thinking there is still an update pending. It's just a bug, which will be fixed this weekend.

@chrisant996
Copy link
Owner

Fixed in v1.3.21.

@arogl
Copy link
Author

arogl commented Jun 12, 2022

@chrisant996 Thank you for your efforts in bringing clink up to date and the on-going fixes and improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants