Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLINK_HISTORY_LABEL doesn't work since v1.3.18 #411

Closed
unuunn opened this issue Jan 25, 2023 · 1 comment
Closed

CLINK_HISTORY_LABEL doesn't work since v1.3.18 #411

unuunn opened this issue Jan 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@unuunn
Copy link

unuunn commented Jan 25, 2023

Hi, I use the environment variable CLINK_HISTORY_LABEL
I set it after clink inject,
recently discovered that history is written to the shared file clink_history.
Rolling back, I found that the last working version was v1.3.17.

If you run the command, the clink history command, the history file is created, but the record still goes to the general clink_history
The clink info at this time shows the correct history file from the CLINK_HISTORY_LABEL variable.

I checked with my own settings and with the default, the behavior is the same.

Notes
If I set CLINK_HISTORY_LABEL before starting clink inject it works correctly.
clink-reload doesn't help
clink history compact and etc doesn't help

Steps to reproduce:

clink.bat
SET CLINK_HISTORY_LABEL=abc123
echo some command for history
REM clink_history-abc123 still doesn't exist
clink history
REM clink_history-abc123 is created
echo some command for history
REM the record is stored in the clink_history

Windows 11 (10.0.22621.1105)

@chrisant996
Copy link
Owner

Thank you for reporting this, and especially thank you for the detailed analysis!

And DOH!

Commit 191807b broke it. When I did a search and replace I didn't notice a side effect. I use CLINK_HISTORY_LABEL, but I happen to set it before the first prompt, so the problem didn't manifest for me.

v1.4.13 will include a fix.

@chrisant996 chrisant996 added bug Something isn't working labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants