Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmder's vendor/clink.lua is no longer loaded #53

Closed
iulian3144 opened this issue Jan 13, 2021 · 2 comments
Closed

Cmder's vendor/clink.lua is no longer loaded #53

iulian3144 opened this issue Jan 13, 2021 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@iulian3144
Copy link

iulian3144 commented Jan 13, 2021

Seems that the vendor/clink.lua is no longer loaded starting with commit dcf44d6370e354237df15116117a85eb8b3cf18f.
I would just like to know if this was intended and the reasons behind it.

@daxgames (I assumed you're Cmder's maintainer based on contributions)
I think this could also be handled in Cmder by simply giving the file a different name (e.g. clink.luacmder_clink.lua).
Maybe you could sync with Cmder's maintainer regarding this to avoid future issues. With the version of clink that cmder is currently using this doesn't occur. I'm using the latest clink version 1.1.19.adf144 and noticed that the completions defined by Cmder are not working anymore.

Another option would probably be to have an exception for clink.lua if the parent dir is vendor but this sounds more like a hack.

Issue fixed with commit d073df557bf4a80a5949dde90da96f6c9ebbf997.

@daxgames
Copy link

We are already working on it. Clink 1.1.20 should already have a fix.

What versions of Cmder and Link are you using now.

@iulian3144
Copy link
Author

iulian3144 commented Jan 13, 2021

We are already working on it. Clink 1.1.20 should already have a fix.

I'll check that out. I think I'll need to fix my comment :).

I am currently using cmder 1.3.17 and clink 1.1.19.adf144

@chrisant996 chrisant996 added bug Something isn't working duplicate This issue or pull request already exists labels Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants