General fixes #1
Conversation
Conflicts: app/src/main/res/layout/item_list_movie.xml app/src/main/res/layout/item_list_movie_sml.xml
| @@ -115,7 +115,7 @@ public void run() { | |||
| } catch (RetrofitError re) { | |||
| retrofitError = re; | |||
| if (Constants.DEBUG) { | |||
| Log.d(getClass().getSimpleName(), "Error while completing network call", re); | |||
| Log.d(((Object) this).getClass().getSimpleName(), "Error while completing network call", re); | |||
There was a problem hiding this comment.
I'm curious to know the reason for this change. It was necesary? I don't think that this change improve readability.
There was a problem hiding this comment.
Because Android Studion was raising an error while I'm looking around the codes. And I found a similar problem on stackoverflow and fixed it according to the accepted answer there.
I think it is a bug in Android Studio. As we know, Android Studio is based on the IntelliJ Platform and the existing functionality of IntelliJ IDEA Community Edition.
Google has developed it in cooperation with JetBrains. And same bug is reported to happen in IntelliJ as well. Have a look at the Error report
However a workaround to this issue is:
Casting the getClass() call to Object as follows:
((Object) this).getClass()
I've bumped the gradle plugin versions, build tool version.
Also I had to add okhttp 1.6.0 and okhttp-urlconnection 1.6.0 because Picasso was raising an Exception. ( Detail here )
At least, I am able to build it and working for me now. Thanks a lot for open sourcing it.