Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included in F-Droid #610

Closed
gbakeman opened this issue May 13, 2020 · 8 comments
Closed

Included in F-Droid #610

gbakeman opened this issue May 13, 2020 · 8 comments

Comments

@gbakeman
Copy link

It would be great to see this project included in the F-Droid repository. Among other things, this would make Tivi more accessible, you can show off screenshots of the app, and test versions can be quickly deployed.

@chrisbanes
Copy link
Owner

chrisbanes commented May 14, 2020

I don't think that this is going to work unfortunately. There are a number of 'secrets' (client IDs, API keys, etc) which are part of the GitHub Actions build, and not committed to the source repo.

@Poussinou
Copy link

Poussinou commented Feb 13, 2022

@chrisbanes Would it be possible to attach the signed apk in the release section with each new tag please?

@chrisbanes
Copy link
Owner

Woops, my bad. I already have this setup as an automated action but I haven't been publishing the draft releases. I'll make sure to do it from now on.

@alexanderadam
Copy link

There are a number of 'secrets' (client IDs, API keys, etc) which are part of the GitHub Actions build, and not committed to the source repo.

Other apps give users the possibility to add own API keys in the settings.
Wouldn't this be a possibility here as well? 🤔

@chrisbanes
Copy link
Owner

Other apps give users the possibility to add own API keys in the settings. Wouldn't this be a possibility here as well? 🤔

PRs welcome!

@alexanderadam
Copy link

Oh, in case you're open to such a solution it would make sense to reopen this issue, doesn't it?
This would likely increase the possibility that someone knowing Kotlin would find this issue.

What do you think?

@chrisbanes
Copy link
Owner

Probably better to open a new issue. This is about pushing F-Droid, not the ability to set your own API keys

@IzzySoft
Copy link

Is there any chance for a more detailed description (what about the app offers, what to expect from it), and maybe some screenshots? While the API key requirement and Firebase are show-stoppers for F-Droid.org, your app might qualify for my repo until it's ready to meet F-Droid's stronger criteria. Inclusion with my repo was even requested already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants