Feature/detect win #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gotta go across, then down to the next level:
1 2 3 4 5 6 7
8 9 10 11 12 13
14 15 16 17 18
19 20 21 22
23 24 25
26 27
28
starting from the top of the deck (end of the deck vector).
Looking up a Stack by AreaId should return an Option, because we don't know if that AreaId is in the AreaList (it should be).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement win detection. This entailed changes in the
SettingsandAreacode to simplify lifetimes.Areas no longer hold a reference to theGameSettingsand instead just copy out the particular fields they care about.I've also introduced the new idea of
Dealers, which are essentially factory objects forGame. It's theDealer's job to generate, order, and place the theCards to create aGame. This makes testing easier because now we have some "cheaty" dealers that always deal in order or always deal a win. There is a hidden setting to set the dealer.Fixes #4.