Job::recreate() encapsulates args array inside another array

[CyrilMazur]

Job::recreate is calling Job::create, which enqueues the job like this

Resque::push($queue, array(
'class' => $class,
'args' => array($args),
'id' => $id,
));

It encapsulates array($args) (don't really know why?)

Anyways, if you call recreate, that will pass array($args) to create() and then encapsulate into another array. So if you all recreate() once, you end up with

array(array($args))

if you call it twice, you end up with

array(array(array($args)))

and so on... thus when performing a job that was enqueued using recreate(), the $args array is wrongly encapsulated into another array.

I fixed this by changing the line 234 of Job.php like this:

return self::create($this->queue, $this->payload['class'], $this->payload['args'][0], $monitor);

(jus added [0] to $this->payload['args'])

[ruudk]

A PR would be better :)

[danhunsaker]

The trouble with a pull request at this point is the question of why $args is being wrapped in an(other) array. Should it, instead, be cast to an array? Knowing why it is wrapped will determine which of the two solutions should be submitted in a PR to begin with.

[ruudk]

True, I found out this:

The encapsulated array() call in Job::create was added 2 years ago in order to be better compatible with the Ruby version: f7eac3b

When you look at Job->getArguments() you'll see that it then returns the first index of the array: https://github.com/chrisboulton/php-resque/blob/master/lib/Resque/Job.php#L128

So this should be correct:

return self::create($this->queue, $this->payload['class'], $this->payload['args'][0], $monitor);

[ruudk]

Maybe $this->getArguments() would be better as it returns an empty array when there are no arguments given. Where $this->payload['args'][0] could throw an undefined index error.

[danhunsaker]

You make it sound like git keeps a record of changes, and if commit messages are actually thoughtfully written, others can go back and see why things are done a certain way! A technology like that would be.... Well, useful.

Said another way: Oh. Right. The answer is probably in the commit history somewhere, and something like git blame would probably help narrow down where. Duh. Should have thought of that.

[CyrilMazur]

yeah $this->getArguments() would be the proper way to do it, like you said, in case $this->payload['args'][0] is undefined. Pull request sent, thanks guys.

[Rockstar04]

It looks like this issue could be closed? Fixed in #104

[CyrilMazur]

True @Rockstar04