-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please upgrade to verifier-version 1.236 as default #1
Comments
+1, thanks @ChrisCarini! |
Thanks for opening this issue @YannCebron ! (and thank you for the commit mentioning this GH action in the official JB documentation, as well! @hsz just let me know about this - awesome!) and thank you @serejke - this is awesome! It looks like GH provides the latest release information (including tag) in
Instead of just bumping to I'll have to strip off the Also, would it be possible that when you tag a release, you also include the |
@ChrisCarini thank you for the suggestion! |
@ChrisCarini What if there'll be a breaking change + bus factor? BTW - I've written Integration section in the intellij-plugin-verifier README, and it's already merged. |
Hi @hsz - do you mind expanding further what you mean exactly for my own understanding?? :) You are correct, there are no tests for the GH action (I'd love to add some, but I'm not actually sure how to besides just using the GH action myself), so I want to better understand. Are you suggesting that if Or (and/or), are you suggesting that adding a check to the latest GH release of If so, we could add something to check if the curl request(s) fail (either for getting the information from GH, or getting the jar file from GH), to call back on some sane default(s). Just throwing out some ideas for discussion! :) Also, thank you for including that on |
Hi All, I just pushed the (very small) change to bump the default version to But...Let's continue this discussion! I have a local branch that will allow a default of Some options I could see:
Option 1Summary: Make Pros
Cons
Option 2Summary: Keep an explicit version of Pros
Cons
Let me know if I'm missing anything or not thinking of something - and as said, let's continue the discussion; I think this could be a really neat thing to have! (As the action creator, I'd love to use |
I vote for Option 1. TBH, I didn't realize then that there is a possibility to override and freeze the version by the user. |
please add @YannCebron for bug, idea, maintenance |
I've put up a pull request to add @YannCebron! 🎉 I've put up a pull request to add @serejke! 🎉 We had trouble processing your request. Please try again later. |
@serejke already contributed before to infra, maintenance I've put up a pull request to add @hsz! 🎉 |
Thanks a lot for this handy Action!
The text was updated successfully, but these errors were encountered: