-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified version not working #1
Comments
I updated the file Are you running UglifyJS on the |
It passes the tests, yes. I think right now that probably I was doing something wrong or is a problem caused by the platform (Tumblr, don't judge me). I just needed But now that I saw your tests passing correctly with the minified version, I tried it in a plunker... and it runs without errors. And tried just now in Fiddle and works all right. And tried in another Tumblr and... It breaks. So it must be something in Tumblr what is messing with the script minified that way... I should have tried that before, I don't know why I didn't do it: this isn't the first weird error Tumblr causes me. I feel very sorry for wasting your time, man. My apologies :(. |
Hey, no worries. I would have done exactly the same in your shoes. Strange to hear that it doesn't work on Tumblr. I'd be interested to hear back from you if you ever can figure out why that is! Meanwhile, I'll close this. |
I don't know if is only me, but the minified version doesn't work. It spills the
error just by loading it, in both, Firefox Developer Edition 47 and Chrome 50, at least.
I had to minify this with ShrinkSafe to get a acceptable size and a working script.
Seems like UglifyJS breaks this particular (because generally it's my chosen one too) code with their «optimizations». And same happens with other alternatives, like Google Closure minifier.
The text was updated successfully, but these errors were encountered: