Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architect changes #43

Closed
ButuzGOL opened this issue Jan 29, 2016 · 4 comments
Closed

Architect changes #43

ButuzGOL opened this issue Jan 29, 2016 · 4 comments

Comments

@ButuzGOL
Copy link
Contributor

Currently I like how it starts

  1. git clone
  2. git push to your project

But then I thought about to move marked and jquery as deps using npm
So I get

  1. git clone
  2. npm install
  3. move files from node_model to lib
  4. git push

Also I thought about steps

  1. npm install -g cms.js
  2. cms.js init
  3. git push

I thought about it because

  1. break project to sep files
  2. use babel
  3. min sources
  4. write test
  5. use dependancy manager
  6. new features for project how to update own project

what do you think ?

@chrisdiana
Copy link
Owner

Yes, I agree there needs a bit of an architecture change. I'm in the process of restructuring the code for easier editing/PRs/setup. We are also probably going to be moving away from jQuery and will probably use bower for marked deps.

I'm leaning towards having the "demo" content in it's own directory because cms.js is basically the only file which changes frequently enough. This way when there are changes to the engine, users can just pull that file instead of demo content, etc. Will most likely also be including grunt in the round of commits.

@ButuzGOL
Copy link
Contributor Author

Please take a look on #48
I did this structure

  1. npm install -g cms.js
  2. cms.js init
  3. git push

So it will resolve all those issues

What do you think ?

@shoostar shoostar mentioned this issue Feb 26, 2016
@chrisdiana
Copy link
Owner

I'm definitely on board with this type of structure. Working with you PR to finalize a solution.

@chrisdiana
Copy link
Owner

We pulled out the starter template from the source code to make maintaining easier in v2. I definitely think it would be great to have a CLI utility. I retitled and created a new issue here to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants