Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of veritcal_rhythm partial. #771

Merged
merged 1 commit into from Mar 12, 2012
Merged

Improve documentation of veritcal_rhythm partial. #771

merged 1 commit into from Mar 12, 2012

Conversation

JohnAlbin
Copy link
Contributor

The docs for the vertical rhythm partial need some love. Here's the love.

@barraponto
Copy link
Contributor

I remember when I was beginner frontender and @JohnAlbin 's Zen base theme for Drupal and @chriseppstein 's SASS and Compass sped me down the highway of frontend and in-browser design... I just feel happy to see you both working together :)

@JohnAlbin
Copy link
Contributor Author

I finally had to go through the vertical_rhythm partial line-by-line to try to understand it. This commit is basically my notes to try to make sense of the partial.

The partial is actually pretty good. Not perfect, but like 90% good. :-)

I've got a boat load of changes I want to improve this partial (including decent rem support), but since my doc changes touch almost every line, it would be easier to get this in first and save the merge conflicts.

chriseppstein added a commit that referenced this pull request Mar 12, 2012
Improve documentation of veritcal_rhythm partial.
@chriseppstein chriseppstein merged commit a700e5d into Compass:stable Mar 12, 2012
@chriseppstein
Copy link
Member

Excellent. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants