Delegate the stylesheet_saved callback to the stylesheet_updated callback of Sass #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back of Sass The stylesheet_saved callback expects the file to be written, whereas the formerly used updating_stylesheet is called before writing the stylesheet. The stylesheet_updated callback has been added to Sass in order to ensure consistent behavior of stylesheet_saved.
|
+1 |
|
I have concerns re: the sass patch that might make this PR unnecessary. |
|
The stylesheet_updating callback has been deprecated in Sass 3.1.11. Please reopen this issue and merge in my commit. See: |
|
I don't know if the changed callback is that important but consider to update the dependency on Sass from ' |
|
Hello @scottdavis, why did you close this issue? I believe Compass uses deprecated Sass callbacks for months now. |
|
@ChristianPeters we use the right callback now: https://github.com/chriseppstein/compass/blob/stable/lib/compass/configuration/helpers.rb#L73-77 |
|
Allright then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stylesheet_saved callback expects the file to be written, whereas the currently used updating_stylesheet is called before writing the stylesheet.
The stylesheet_updated callback has been added to Sass in order to fix this problem:
sass/sass#151
This change is necessary to ensure a consistent and expected behavior of the stylesheet_saved callback. Note that it is also invoked after writing the stylesheet in Compass::Compiler#compile: https://github.com/chriseppstein/compass/blob/stable/lib/compass/compiler.rb#L141