Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow to opt out of certain features #1

Closed
1 task done
premell opened this issue Mar 27, 2023 · 2 comments
Closed
1 task done

Feature Request: Allow to opt out of certain features #1

premell opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@premell
Copy link

premell commented Mar 27, 2023

Feature Requested

Since your plugin has multiple very opinionated features it would be nice to be able to opt in and out of them independently. For instance if you want to skip insignificant punctuation but dont want to jump by subwords. I dont think this would be to hard to do either, just have them options for each feature:

opts = {
  skipInsignificantPunctionations = false,
  jumpSubWords = true
}

These could be defaulted to true so that its not annoying to setup. This would be even more useful if you ever consider adding more features to the plugin. And it will allow you to be less constrained by which features you add. (you dont have to have everyone like the feature)

Relevant Screenshot

No response

Checklist

  • The feature would be useful to more users than just me.
@premell premell added the enhancement New feature or request label Mar 27, 2023
@chrisgrieser
Copy link
Owner

Makes sense. I added an option to disable the punctuation skipping:

require("spider").setup({
	skipInsignificantPunctuation = true
})

I didn't implement the disabling of movement by subwords since I assume that it is the core feature people are using this plugin for (if I am wrong on this, please open a new issue and I'll add an option for that later)

@chrisgrieser
Copy link
Owner

For instance if you want to skip insignificant punctuation but dont want to jump by subwords.

There is now an option to do exactly that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants