-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema is not generated with validation when comment includes Japanese #118
Comments
@manak1 thanks for pointing this out. since I'm using regexes quite heavily to validate if the user input is valid this problem happens becaues I do not check for Japanese characters since I do not speak nor can I read your language - so sadly Ihave no idea how to check for these characters 馃槩 maybe you could open a PR or provide some info on how to check for Japanese in a regex? |
@chrishoermann |
Not sure how helpful this still might be, but this should work to match all Japanese text:
Which is the same as (using the combined hiragana / katakana unicode script identifier):
Explanations can be found here: Note I've also included the 'Han' script identifier, i.e. all of the possible Kanji. EDIT: I've validated through a regex validator, and the "Hrkt" identifier doesn't work on ECMAScript regex, so please use the first version, with the separate hiragana / katakana identifiers. |
I implemented the behaviour as suggested by @dbtl88 and according to my tests it works. Would be nice if someone could confirm this with a more extended range of japanese characters than the ones I used in my tests. |
Hello, Thank you for creating a wonderful package!
I have a problem generating schema with validation using Japanese error message.
Is there any workaround for this problem? 馃憖
Expected output
Actual output
The text was updated successfully, but these errors were encountered: